build and test each crate separately #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
test-each-crate
branch
from
2f1126a to
7adba5d
Compare
conradoplg
force-pushed
the
test-each-crate
branch
from
7adba5d to
6b9e1fe
Compare
7 tasks
natalieesk
pushed a commit
that referenced
this pull request
Jun 27, 2024
* build and test each crate separately * frost-core: fix benchmark compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo test -p frost-corewas failing because the benchmark was failing to build, which in turn was being caused by thecriteriondependency not being included when compiling without features.This was not being caught because on CI we just use
cargo test, which merges all features and would end up includingcriterion.This was also not being caught by the all-features test because we were only doing
build(which does not build benchmarks) and nottest(which does build benchmarks).This fixes the issue, and adds test-all-features to CI, which already works on each crate separately.