Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serialization methods consistent #674

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

conradoplg
Copy link
Contributor

Depends on #671

Closes #661

@conradoplg conradoplg requested a review from natalieesk June 12, 2024 23:02
@mpguerra mpguerra linked an issue Jun 18, 2024 that may be closed by this pull request
Base automatically changed from deserialize-error-on-identity to main June 19, 2024 13:21
@conradoplg conradoplg force-pushed the consistent-serialization branch from c08427b to d46f68a Compare June 19, 2024 18:02
@conradoplg conradoplg force-pushed the consistent-serialization branch from d46f68a to fec845e Compare June 19, 2024 21:58
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot merged commit e7b631a into main Jun 20, 2024
20 checks passed
@mergify mergify bot deleted the consistent-serialization branch June 20, 2024 15:57
natalieesk pushed a commit that referenced this pull request Jun 27, 2024
* make serialization consistent

* fix SignatureShare and Identifier serialization

* Update frost-core/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make serialization methods consistent
2 participants