Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all HashMaps to BTreeMaps #547

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Convert all HashMaps to BTreeMaps #547

merged 2 commits into from
Sep 22, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #476

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 2370b44):

https://frost-book--pr547-hashmap-to-btreemap-plywv6ar.web.app

(expires Fri, 06 Oct 2023 13:16:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 29.82% and project coverage change: -0.02% ⚠️

Comparison is base (a5dc479) 81.43% compared to head (2370b44) 81.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.02%     
==========================================
  Files          30       30              
  Lines        3027     3025       -2     
==========================================
- Hits         2465     2463       -2     
  Misses        562      562              
Files Changed Coverage Δ
frost-ed25519/src/keys/dkg.rs 0.00% <0.00%> (ø)
frost-ed25519/src/keys/repairable.rs 59.09% <0.00%> (ø)
frost-ed25519/src/lib.rs 64.06% <0.00%> (ø)
frost-ed448/src/keys/dkg.rs 0.00% <0.00%> (ø)
frost-ed448/src/keys/repairable.rs 59.09% <0.00%> (ø)
frost-ed448/src/lib.rs 64.06% <0.00%> (ø)
frost-p256/src/keys/dkg.rs 0.00% <0.00%> (ø)
frost-p256/src/keys/repairable.rs 59.09% <0.00%> (ø)
frost-p256/src/lib.rs 68.27% <0.00%> (ø)
frost-ristretto255/src/keys/dkg.rs 0.00% <0.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mergify mergify bot merged commit ba3ef7d into main Sep 22, 2023
@mergify mergify bot deleted the hashmap_to_btreemap_476 branch September 22, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all HashMaps with BTreeMaps
2 participants