remove serde bounds from Ciphersuites #541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
derive
, serde adds bounds to (De)Serialize even to the Ciphersuite itself, even though that's not required. That is annoying because it requires us to add the bounds to all ciphersuite structs, but more importantly, is making things much harder in #525 since it needs to use the new default serialization methods which require serde.This uses
serde(bound = "C: Ciphersuite")
to remove those bounds. See https://stackoverflow.com/questions/76107066/how-to-help-deserializer-understand-that-generics-dont-need-deserialize-bound.Part of #525 but does not close it.