Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove serde bounds from Ciphersuites #541

Merged
merged 1 commit into from
Sep 21, 2023
Merged

remove serde bounds from Ciphersuites #541

merged 1 commit into from
Sep 21, 2023

Conversation

conradoplg
Copy link
Contributor

When using derive, serde adds bounds to (De)Serialize even to the Ciphersuite itself, even though that's not required. That is annoying because it requires us to add the bounds to all ciphersuite structs, but more importantly, is making things much harder in #525 since it needs to use the new default serialization methods which require serde.

This uses serde(bound = "C: Ciphersuite") to remove those bounds. See https://stackoverflow.com/questions/76107066/how-to-help-deserializer-understand-that-generics-dont-need-deserialize-bound.

Part of #525 but does not close it.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (eee505a) 81.17% compared to head (cd76621) 81.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   81.17%   81.31%   +0.13%     
==========================================
  Files          30       30              
  Lines        3012     3007       -5     
==========================================
  Hits         2445     2445              
+ Misses        567      562       -5     
Files Changed Coverage Δ
frost-core/src/frost.rs 92.36% <ø> (ø)
frost-core/src/frost/identifier.rs 98.76% <ø> (ø)
frost-core/src/frost/keys.rs 98.42% <ø> (ø)
frost-core/src/frost/keys/dkg.rs 89.13% <ø> (ø)
frost-core/src/frost/round1.rs 92.65% <ø> (ø)
frost-core/src/frost/round2.rs 100.00% <ø> (ø)
frost-core/src/verifying_key.rs 98.18% <ø> (ø)
frost-ed25519/src/lib.rs 64.06% <ø> (+0.49%) ⬆️
frost-ed448/src/lib.rs 64.06% <ø> (+0.49%) ⬆️
frost-p256/src/lib.rs 68.27% <ø> (+0.46%) ⬆️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Sep 21, 2023
@mergify mergify bot merged commit a5dc479 into main Sep 21, 2023
@mergify mergify bot deleted the remove-serde-bounds branch September 21, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate randomizer by hashing SigningPackage
2 participants