add version field to serialization at the beginning; move ciphersuite after it #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a Header field to the structs as dicussed.
This also changes the Ciphersuite::ID to be the contextString from the spec, per @dconnolly 's suggestion. My arguments in favor of that are:
I didn't change Ciphersuite::ID to be Ciphersuite::CONTEXT_STRING because it doesn't seem to gain us much, but I'm still undecided, feedback is welcome.
Closes #534