Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version field to serialization at the beginning; move ciphersuite after it #540

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

conradoplg
Copy link
Contributor

This also adds a Header field to the structs as dicussed.

This also changes the Ciphersuite::ID to be the contextString from the spec, per @dconnolly 's suggestion. My arguments in favor of that are:

  • It's something concrete from the spec, rather then the old value which does not have a specific name
  • It includes a version. If the ciphersuite in the spec changes for whatever reason and contextString changes, then it's basically a new ciphersuite and any serialized FROST structs for that ciphersuite will be incompatible

I didn't change Ciphersuite::ID to be Ciphersuite::CONTEXT_STRING because it doesn't seem to gain us much, but I'm still undecided, feedback is welcome.

Closes #534

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Visit the preview URL for this PR (updated for commit 81f4ac1):

https://frost-book--pr540-add-version-m7reip8v.web.app

(expires Mon, 02 Oct 2023 17:22:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b7f43333fbf8fa5527ab3f0dd7bd10bb1fa7401c

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (eee505a) 81.17% compared to head (81f4ac1) 81.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   81.17%   81.29%   +0.12%     
==========================================
  Files          30       30              
  Lines        3012     3032      +20     
==========================================
+ Hits         2445     2465      +20     
  Misses        567      567              
Files Changed Coverage Δ
frost-ed25519/src/lib.rs 63.56% <ø> (ø)
frost-ed448/src/lib.rs 63.56% <ø> (ø)
frost-p256/src/lib.rs 67.80% <ø> (ø)
frost-ristretto255/src/lib.rs 63.77% <ø> (ø)
frost-secp256k1/src/lib.rs 67.58% <ø> (ø)
frost-core/src/frost.rs 92.36% <100.00%> (ø)
frost-core/src/frost/keys.rs 98.42% <100.00%> (ø)
frost-core/src/frost/keys/dkg.rs 89.13% <100.00%> (ø)
frost-core/src/frost/keys/repairable.rs 97.14% <100.00%> (ø)
frost-core/src/frost/round1.rs 92.65% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos but otherwise looks good.

@mergify mergify bot merged commit 4ba88c0 into main Sep 20, 2023
@mergify mergify bot deleted the add-version branch September 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version field to serialization at the beginning; move ciphersuite after it
2 participants