Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for BindingFactor, BindingFactorList and SigningShare functions #576

Closed
3 tasks done
natalieesk opened this issue Nov 15, 2023 · 0 comments · Fixed by #578
Closed
3 tasks done

Fix warnings for BindingFactor, BindingFactorList and SigningShare functions #576

natalieesk opened this issue Nov 15, 2023 · 0 comments · Fixed by #578

Comments

@natalieesk
Copy link
Contributor

natalieesk commented Nov 15, 2023

We're getting the following warnings. Either we should remove the unused functions or add tests for them.

warning: associated function `deserialize` is never used
   --> src/lib.rs:189:12
    |
184 | impl<C> BindingFactor<C>
    | ------------------------ associated function in this implementation
...
189 |     pub fn deserialize(
    |            ^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: method `iter` is never used
   --> src/lib.rs:231:12
    |
220 | impl<C> BindingFactorList<C>
    | ---------------------------- method in this implementation
...
231 |     pub fn iter(&self) -> impl Iterator<Item = (&Identifier<C>, &BindingFactor<C>)> {
    |            ^^^^

warning: associated function `from_coefficients` is never used
   --> src/keys.rs:120:19
    |
88  | impl<C> SigningShare<C>
    | ----------------------- associated function in this implementation
...
120 |     pub(crate) fn from_coefficients(coefficients: &[Scalar<C>], peer: Identifier<C>) -> Self {
    |  
  • BindingFactor::deserialize()
  • BindingFactorList::iter()
  • SigningShare::from_coefficients()
natalieesk added a commit that referenced this issue Nov 15, 2023
@mergify mergify bot closed this as completed in #578 Nov 16, 2023
mergify bot pushed a commit that referenced this issue Nov 16, 2023
* Use from_coefficients() instead of evaluate_polynomial() when computing a signing_share (#576)

* Refactor BindingFactor::deserialize into from_hex as it's only used for testing (#576)

* Remove BindingFactorList::iter() and use directly in vector test (#576)
@github-project-automation github-project-automation bot moved this to Done in FROST Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant