Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: remove signers or refresh shares with trusted dealer #245

Closed
natalieesk opened this issue Feb 15, 2023 · 4 comments · Fixed by #281 or #665
Closed

Feature: remove signers or refresh shares with trusted dealer #245

natalieesk opened this issue Feb 15, 2023 · 4 comments · Fixed by #281 or #665
Assignees
@natalieesk
Labels
C-feature Category: New features

Comments

@natalieesk
Copy link
Contributor

natalieesk commented Feb 15, 2023 •
edited
Loading

Motivation

There may be situations where you may want to remove signers.

Design

To do this you would need to perform a resharing protocol and leave out the relevant participant.

This is done by basically redoing the trusted dealer generation with a "zero" secret, and adding the new shares to the old ones, while keeping only the participants that are wanted

References
@natalieesk natalieesk added question Further information is requested frost labels Feb 15, 2023
@chelseakomlo chelseakomlo changed the title Feature: remove signers Feature: remove signers or refresh shares Feb 21, 2023
@chelseakomlo
Copy link
Collaborator

I changed this issue to "remove signers or refresh shares" since the technique is the same.

@chelseakomlo
Copy link
Collaborator

Completed

@mpguerra mpguerra linked a pull request May 23, 2023 that will close this issue
Add repair share functionality #281
Merged
@conradoplg
Copy link
Contributor

Reopening, we just implemented repair share, refresh/remove is still missing

@conradoplg conradoplg reopened this May 24, 2023
@mpguerra mpguerra added this to FROST Aug 24, 2023
@mpguerra mpguerra moved this to Product Backlog in FROST Aug 24, 2023
@conradoplg conradoplg mentioned this issue Sep 4, 2023
Closed
@mpguerra mpguerra removed the frost label Sep 6, 2023
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in FROST Sep 26, 2023
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in FROST Oct 3, 2023
@mpguerra mpguerra moved this from Review/QA to Sprint Backlog in FROST Oct 3, 2023
@mpguerra mpguerra moved this from Sprint Backlog to In Progress in FROST Oct 9, 2023
@mpguerra mpguerra moved this from In Progress to Sprint Backlog in FROST Oct 10, 2023
@mpguerra
Copy link
Contributor

@natalieesk can you please split this one up and we turn it into a tracking issue instead

@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in FROST Oct 24, 2023
@conduition conduition mentioned this issue Nov 6, 2023
Closed
5 tasks
@conduition conduition mentioned this issue Feb 20, 2024
Draft
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in FROST Mar 18, 2024
@mpguerra mpguerra assigned mpguerra and natalieesk and unassigned mpguerra Mar 25, 2024
@natalieesk natalieesk added C-feature Category: New features and removed question Further information is requested labels May 22, 2024
@natalieesk natalieesk changed the title Feature: remove signers or refresh shares Feature: remove signers or refresh shares with trusted dealer May 22, 2024
@mpguerra mpguerra moved this from Sprint Backlog to In Progress in FROST May 28, 2024
natalieesk added a commit that referenced this issue May 29, 2024
@natalieesk
Add refresh shares with dealer functionality (#245)
fff737d
natalieesk added a commit that referenced this issue May 29, 2024
@natalieesk
Add refresh shares with dealer functionality (#245)
e450420
@natalieesk natalieesk mentioned this issue May 29, 2024
Merged
@mpguerra mpguerra moved this from In Progress to Review/QA in FROST May 29, 2024
natalieesk added a commit that referenced this issue Jun 11, 2024
@natalieesk
Change refresh share API (#245)
92f0715 
Split refresh_shares_with_dealer into calculate_zero_key and refresh_share
natalieesk added a commit that referenced this issue Jun 27, 2024
@natalieesk
Fix serialisation error with refresh share (#245)
f649e31 
Add serialisation test
natalieesk added a commit that referenced this issue Jun 27, 2024
@natalieesk
Fix serialisation errors after updates (#245)
081b35c 
Fixed some typos
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Update refresh_share to accept and return a KeyPackage instead of Sec…
ff7e6d9 
…retShare (#245)
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Tidy up refresh share functionality (#245)
0b141ea
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Add refresh share functionality to Book (#245)
71666ea 
Diagram is still to be added
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Add refresh shares with dealer functionality (#245)
af48c74
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Change refresh share API (#245)
dcbadd6 
Split refresh_shares_with_dealer into calculate_zero_key and refresh_share
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Fix serialisation error with refresh share (#245)
2a72427 
Add serialisation test
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Fix serialisation errors after updates (#245)
f2e6d32 
Fixed some typos
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Update refresh_share to accept and return a KeyPackage instead of Sec…
a640cfd 
…retShare (#245)
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Tidy up refresh share functionality (#245)
fdde54a
natalieesk added a commit that referenced this issue Jul 4, 2024
@natalieesk
Add refresh share functionality to Book (#245)
42f3ebe 
Diagram is still to be added
natalieesk added a commit that referenced this issue Jul 10, 2024
@natalieesk
Update book for rereshing shares with trusted dealer (#245)
1f0d92f
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Add new verifying shares calculation for refresh shares (#245)
6bb17f2 
Add tests for invalid identifiers when refreshing shares
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Rename calculate_zero_key to compute_refreshing_shares (#245)
fd3886e
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Import Vec from the alloc crate (#245)
95dac77 
This is to be compatible with the no_std attribute
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Use alloc crate instead of std for refresh shares (#245)
0711879
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Fix fmt error (#245)
0a829a9
natalieesk added a commit that referenced this issue Jul 18, 2024
@natalieesk
Refactoring refresh shares functionality (#245)
b1731b6
mergify bot pushed a commit that referenced this issue Jul 18, 2024
@natalieesk @conradoplg
Add refresh shares with dealer functionality (#665)
835a3f0 
* Add refresh shares with dealer functionality (#245)

* Change refresh share API (#245)

Split refresh_shares_with_dealer into calculate_zero_key and refresh_share

* Fix serialisation error with refresh share (#245)

Add serialisation test

* Fix serialisation errors after updates (#245)

Fixed some typos

* Update refresh_share to accept and return a KeyPackage instead of SecretShare (#245)

* Tidy up refresh share functionality (#245)

* Add refresh share functionality to Book (#245)

Diagram is still to be added

* Update book for rereshing shares with trusted dealer (#245)

* Add new verifying shares calculation for refresh shares (#245)

Add tests for invalid identifiers when refreshing shares

* Rename calculate_zero_key to compute_refreshing_shares (#245)

* Import Vec from the alloc crate (#245)

This is to be compatible with the no_std attribute

* Use alloc crate instead of std for refresh shares (#245)

* Fix fmt error (#245)

* Refactoring refresh shares functionality (#245)

* cleanups during review

* Update book/src/tutorial/refreshing-shares.md

* update docs

* always return error in detect_cheater

* add changelog entry

---------

Co-authored-by: Conrado Gouvea <[email protected]>
Co-authored-by: Conrado Gouvea <[email protected]>
@mergify mergify bot closed this as completed in #665 Jul 18, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natalieesk natalieesk

Labels
C-feature Category: New features
Projects
FROST
Archived in project
Milestone
No milestone
4 participants
@conradoplg @mpguerra @chelseakomlo @natalieesk