Fix clippy issue.

ZcashFoundation · Aug 28, 2023 · 0345633 · 0345633
1 parent 59acb0f
commit 0345633
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/frost-core/src/frost/keys.rs b/frost-core/src/frost/keys.rs
@@ -48,7 +48,7 @@ pub(crate) fn compute_public_key<C: Ciphersuite>(
 ) -> VerifyingKey<C> {
     let mut group_public = <C::Group>::identity();
     for commitment in commitments.values() {
-        group_public = group_public + commitment.first().unwrap().value();
+        group_public = group_public + commitment.first().expect("valid commitments").value();
     }
     VerifyingKey {
         element: group_public,

diff --git a/frost-core/src/frost/keys/dkg.rs b/frost-core/src/frost/keys/dkg.rs
@@ -449,7 +449,7 @@ pub fn part3<C: Ciphersuite>(
     let signing_share = SigningShare(signing_share);
 
     let commitments = round1_packages
-        .into_iter()
+        .iter()
         .map(|(peer, package)| (*peer, package.commitment.clone()))
         .chain(iter::once((
             round2_secret_package.identifier,
@@ -463,7 +463,7 @@ pub fn part3<C: Ciphersuite>(
         public: *public_key_package
             .signer_pubkeys
             .get(&round2_secret_package.identifier)
-            .unwrap(),
+            .expect("round2_secret_package.commitment is in the hashmap"),
         group_public: public_key_package.group_public,
         ciphersuite: (),
     };

diff --git a/frost-ristretto255/tests/common_traits_tests.rs b/frost-ristretto255/tests/common_traits_tests.rs
@@ -1,4 +1,5 @@
 #![cfg(feature = "serde")]
+#![allow(clippy::unnecessary_literal_unwrap)]
 
 mod helpers;