Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1: also send randomizer #140

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Phase 1: also send randomizer #140

merged 2 commits into from
Feb 21, 2024

Conversation

conradoplg
Copy link
Contributor

Depends on #138 .

I also changed a bit the semantic of the cli flag. After thinking about it, I think it makes more sense for it to control only whether to use sockets comms or CLI "comms" and not how inputs to the program are read. So now it should be possible to e.g. read the message from the CLI even if socket comms are used, if the user wishes to.

@conradoplg conradoplg requested a review from natalieesk February 2, 2024 15:25
Base automatically changed from phase1-cleanup to main February 9, 2024 17:29
Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@natalieesk natalieesk merged commit cb77d35 into main Feb 21, 2024
6 checks passed
@natalieesk natalieesk deleted the phase1-randomizer branch February 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants