Add socket comms for Participant demo #131
Conversation
Remove group signature verification from participant demo
…to socket_comms_participant_92
| let _ = handler | ||
| .network() | ||
| .listen(Transport::FramedTcp, addr) | ||
| .unwrap(); | ||
| .map_err(|e| println!("{}", e)); |
There was a problem hiding this comment.
Why was this needed? This prints the error but ignores it, continuing to run
There was a problem hiding this comment.
Oops! I was debugging. I can remove.
| @@ -16,7 +16,7 @@ pub struct CommitmentsConfig { | |||
| pub signer_commitments: BTreeMap<Identifier, SigningCommitments>, | |||
| } | |||
|
|
|||
| pub fn step_2( | |||
| pub async fn step_2( | |||
There was a problem hiding this comment.
Why is this async now? Doesn't seem to need to
There was a problem hiding this comment.
Yes it doesn't need to be. I can't remember why I put that there, but I meant to remove it.
| pub fn generate_nonces_and_commitments( | ||
| key_package: &KeyPackage, | ||
| rng: &mut ThreadRng, | ||
| ) -> (SigningNonces, SigningCommitments) { | ||
| let (nonces, commitments) = frost::round1::commit(key_package.signing_share(), rng); | ||
|
|
||
| // TODO: Store nonces | ||
|
|
||
| (nonces, commitments) | ||
| } | ||
|
|
There was a problem hiding this comment.
This doesn't seem to be needed
| identifier: Identifier, | ||
| #[cfg(feature = "redpallas")] randomizer: frost::round2::Randomizer, | ||
| ) -> Result<SigningPackage, Box<dyn Error>>; | ||
|
|
There was a problem hiding this comment.
The randomizer should be an output here, not an input, and should be send by the Coordinator (I also got it wrong and forgot to send the randomizer in the Coordinator). We need to figure out the best way to do this, but I think we could go with the "ugly" solution of returning a (SigningPackage, Randomizer) tuple if redpallas is enabled. But let's do this in a separate PR and make it sure it works with Ed25519 first.
This closes #92
The coordinator server has already been set up and this creates the option of using the participant demos as a client
The group signature verification has been removed from the participant demo as it's not needed