Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to curve25519-dalek-ng #38

Closed
wants to merge 1 commit into from
Closed

Update to curve25519-dalek-ng #38

wants to merge 1 commit into from

Conversation

hdevalence
Copy link
Contributor

Updates the curve25519-dalek dependency in the 2.x series to the -ng version at zkcrypto https://github.com/zkcrypto/curve25519-dalek-ng

@hdevalence hdevalence mentioned this pull request Feb 2, 2021
Closed
@dconnolly
Copy link
Contributor

Thanks for letting us know about the changes to these crates.

It looks like the -ng crates differ from curve25519-dalek by upgrading rand_core to 0.6 and exposing it in the public API. We currently do not need to support rand_core 0.6.

If -dalek does not upgrade rand as we need it, or -ng introduces other features we need, we will revisit switching to -ng. But for now we'll stick with curve25519-dalek.

@dconnolly dconnolly closed this Feb 11, 2021
@str4d str4d mentioned this pull request Feb 20, 2021
Merged
@dconnolly dconnolly mentioned this pull request Sep 7, 2021
Closed
hdevalence added a commit to penumbra-zone/ed25519-consensus that referenced this pull request Sep 16, 2021
@hdevalence
Fork ed25519-zebra to ed25519-consensus.
8c0007e 
This code is generally useful beyond Zebra, but the original upstream
made uncomfortable dependency choices:

* ZcashFoundation/ed25519-zebra#38
* zcash/zcash#4993 (comment)

This commit forks and renames the library, updates the dependencies, and
removes Zcash-specific language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdevalence @dconnolly