More OAuth2 extensions #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this breaks the API of the `CreateAuthorizationRequest` and `GetBearerToken[Async]` methods (due to additional parameters). This also slightly tweaks the bodies of requests, putting each form parameter on a separate line (mainly results in more readable traces).
The email address in the user info is now considered optional (because it is only returned when the `email` scope has been granted). The documentation for `GetUserInfo[Async]` now mentions this, as well as the requirement for the `profile` scope to have been granted. This also renames `AuthorizationScope.EMail` to `AuthorizationScope.Email`.
Zastai
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PKCE support, and adjusts the user info retrieval to handle the case where the email scope has not been grated.