Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code style #27

Merged
merged 10 commits into from
Nov 26, 2021
Merged

Update code style #27

merged 10 commits into from
Nov 26, 2021

Conversation

Zastai
Copy link
Owner

@Zastai Zastai commented Nov 26, 2021

This includes

  • file-scoped namespaces
  • target-typed new
  • new braces style (i.e. braces even when contents span a single line)
  • Rider processing:
    • Code cleanup
    • Resolve all inspections
  • Canonical null checks (is [not] null, ??)
  • Lines wrapped at column 132

This also adds a previously-omitted Languages property to IWork.

Zastai added 10 commits November 22, 2021 23:24
@Zastai
Switch to file-scoped namespaces
2e5161d
@Zastai
Apply braces style
84a75f8
@Zastai
Use target-typed new
d833789
@Zastai
Applied Rider code cleanup
9b04036
@Zastai
Cleaned up long lines
8112b23 
Wrap at column 132; mostly comments and string literals.
@Zastai
Use langword in XML Doc comments
1705b24 
For `null`, `true` and `false`.
@Zastai
Adjust #pragma directives
b3a2db3 
Rider sadly does not use the diagnostic ID specified on `[Obsolete]`,
so it still complains about `WebRequest`. So disable the `CS0618`
compiler message for now as well.
@Zastai
Add missing Languages property to IWork
abae1d1 
This was present on the underlying object but never exposed.
@Zastai
Tweak code to satisfy Rider inspection
a9caa50 
This also disables the "property can be made init-only" and "use
deconstruction" inspections, because the resulting code does not
compile for all targets.
@Zastai
Canonicalize all null checks
1c293af 
They will now all be `is null` or `is not null`, instead of mixing
`== null`, `!= null`, `object.ReferenceEquals(..., null)` and
`.HasValue`.
This also drops all uses of `GetValueOrDefault` in favour of `??`.
@Zastai Zastai merged commit 9772066 into main Nov 26, 2021
@Zastai Zastai deleted the update-code-style branch November 26, 2021 20:37
@Zastai Zastai added feature A new feature or API was added (requires a bump of the minor version) maintenance Internal changes that do not impact functionality or API labels Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature A new feature or API was added (requires a bump of the minor version) maintenance Internal changes that do not impact functionality or API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zastai