Update emscripten #7473
Merged
Update emscripten #7473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version of emscripten used in CI. There have been a bunch of changes, but fortunately only a few of those changes were breaking this project:
terminateAllThreadsis called, which is good but requires us to tweak our wrapper for calling things off the main thread to set a useless timeout in order to prevent node from exiting early (see keeping node alive while workers are working emscripten-core/emscripten#23092)DEMANGLE_SUPPORToption is removed (because traces are now always human readable)Hopefully this makes it buildable in code spaces again.
While I was here I also updated Prettier and TypeScript (the latter of which required a small tweak to the BitVector types).