update unit_lim to the correct value #7423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In z3's co-processing, the units from every thread will be shared at the end of each round.
z3/src/smt/smt_parallel.cpp
Lines 110 to 138 in 3896e18
The code will share the units indexed from
unit_lim[i]
topctxs[i].assigned_literals().size()
. However, after the sharing, newunit_lim[i]
will be set tounit_trail.size()
, which is usually larger than currentpctxs[i].assigned_literals().size()
. As a result, the units indexed frompctxs[i].assigned_literals().size()
tounit_trail.size()
will not be shared in the future.To fix this problem, the new
unit_lim[i]
should just be the number of current units in this thread(pctxs[i].assigned_literals().size()
)