Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new heap invariants #7298

Merged
merged 3 commits into from
Jul 19, 2024
Merged

new heap invariants #7298

merged 3 commits into from
Jul 19, 2024

Conversation

ChuyueSun
Copy link
Contributor

Note that the second new invariant (All indices in m_value2indices that are not used in m_values should be 0) is expensive to check. So should not be turned on during runtime.

NikolajBjorner
NikolajBjorner reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@NikolajBjorner NikolajBjorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENSURE is actually a macro for VERIFY. If you replace it, then use VERIFY.
This allows running the heap unit test in release mode to quicker cover more cases.

@ChuyueSun
Copy link
Contributor Author

ENSURE is actually a macro for VERIFY. If you replace it, then use VERIFY. This allows running the heap unit test in release mode to quicker cover more cases.

Sounds good.

@NikolajBjorner NikolajBjorner merged commit 80ac7b3 into Z3Prover:master Jul 19, 2024
11 of 13 checks passed
@ChuyueSun
Copy link
Contributor Author

ENSURE is actually a macro for VERIFY. If you replace it, then use VERIFY. This allows running the heap unit test in release mode to quicker cover more cases.

Actually, I don't understand the difference between these two. Seems to me that ENSURE is an alias for VERIFY.

NikolajBjorner added a commit that referenced this pull request Jul 22, 2024
@NikolajBjorner
Revert "new heap invariants (#7298)"
dc023e7 
This reverts commit 80ac7b3.
@NikolajBjorner NikolajBjorner mentioned this pull request Jul 22, 2024
Merged
NikolajBjorner added a commit that referenced this pull request Jul 22, 2024
@NikolajBjorner
Revert "new heap invariants (#7298)" (#7303)
966c9a3 
This reverts commit 80ac7b3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolajBjorner NikolajBjorner NikolajBjorner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChuyueSun @NikolajBjorner