Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrooted layout fix #273

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Unrooted layout fix #273

merged 3 commits into from
Jan 25, 2020

Conversation

brj1
Copy link
Contributor

@brj1 brj1 commented Jan 24, 2020

Hi Guangchuang,

I was trying to use the unrooted layouts in ggtree and I found that my trees always came out looking squished. Looking in the code I noticed that in ggtree function a yscale is added to the plot expanding the yscale by 0.6, which is more than my tree's length. Hence, I changed the ggtree function to use "coord_fixed` instead to plot with an 1:1 aspect ratio, which I think make more sense as a default.

I also wrote in ape's unrooted layout. Though I didn't make it work with variable branch.lengths yet.

I put these changes in separate commits in case you don't want the ape layout.

@brj1 brj1 closed this Jan 24, 2020
@brj1
Copy link
Contributor Author

brj1 commented Jan 24, 2020

I decided to change the ape unrooted layout to call the ape::unrooted.xy instead of using its code. I need to test it before I reopen this PR.

@brj1
Copy link
Contributor Author

brj1 commented Jan 24, 2020

I've changed the ape unrooted layout I added to directly call ape::unrooted.xy to ensure that the x, y coordiantes are the same as in ape.

@brj1 brj1 reopened this Jan 24, 2020
@GuangchuangYu GuangchuangYu merged commit dad7eaa into YuLab-SMU:master Jan 25, 2020
@GuangchuangYu
Copy link
Member

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants