Add annotation functions for unrooted tree layouts and other fixes. #152
Conversation
Add updates from GCY ggtree.
PR from Guang Chuang Yu repo.
… unrooted trees. Fixed layoutDaylight ave_change calculation. Fixed bug in getTreeArcAngles() for cases where the branch root node and origin node are the same. Added getNodeEuclDistances() function. Fixed isTip() function to check if nodes has children, instead of checking of the data variable had the isTip field set.
Merge branch 'master' of https://github.com/JustGitting/ggtree # Conflicts: # R/geom_cladelabel.R # R/tidytree.R
…le tree/branch was rotated.
Merge remote-tracking branch 'upstream/master' # Conflicts: # R/geom_cladelabel.R # R/geom_hilight.R
|
Can you explain why you change the parameter at https://github.com/GuangchuangYu/ggtree/pull/152/files#diff-b67b4c9e48f0ba337b73d00861518a6fR41? |
|
FYI: I have fixed the R check 9653250. BTW: You can add your name in author list https://github.com/GuangchuangYu/ggtree/blob/master/DESCRIPTION#L6-L10. |
If you mean this function:
I only changed the parameter names that made it clearer what the parameters meant. My understand was that "tip" is a tree tip and "anc" is the tips ancester. I felt it was a bit better than tip1 and tip2... but I could be wrong, please change back if you need to. |
|
I change them to |
Hi,
I've added/modified the annotation functions to annotate the clades of the unrooted tree layouts. I've also fixed the labels for unrooted trees so they are easier to read.
Cheers,
JG