Interim fix for NPM module version mismatches #5685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile specifies NPM modules to be installed. However, some do not specify a version, so the latest is installed. Later in meshcentral.js mainStart() specific versions are required. If they don't match the latest version, all modules will be reinstalled to get the specific versions. Ylianst#5684 Soft version conflict on NPM modules causes NPM modules to be installed on startup in Docker Ylianst#5545 Docker on Debian 11 fails on version 1.1.15 and 1.1.16 giving NPM errors Ylianst#5681 InstallModules() installs all modules, not just missing modules (regression)
|
Thank u for this, I will look into it and check it's OK, then merge if so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align and specify NPM module versions
The Dockerfile specifies NPM modules to be installed. However, some do not specify a version, so the latest is installed. Later in meshcentral.js mainStart() specific versions are required. If they don't match the latest version, all modules will be reinstalled to get the specific versions.
Fixes #5684 Soft version conflict on NPM modules causes NPM modules to be installed on startup in Docker
Fixes #5545 Docker on Debian 11 fails on version 1.1.15 and 1.1.16 giving NPM errors
Fixes #5681 InstallModules() installs all modules, not just missing modules (regression)