Paasta rollback now accepts none, one or a list of instances. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are wrong it will give a warning.
| def validate_given_instances(service, args_instances): | ||
| """Trying to find which instances are actually valid for the given service""" | ||
| service_instances = list_all_instances_for_service(service) | ||
| invalid_instances = None |
There was a problem hiding this comment.
use an empty list rather than None here
|
I've done most of the suggested changes, thanks for the feedback! Please let me know if there's anything else that could be improved :) |
| ).completer = lazy_choices_completer(list_services) | ||
|
|
||
| list_parser.set_defaults(command=paasta_rollback) | ||
|
|
||
|
|
||
| def validate_given_instances(service_instances, args_instances): | ||
| """Trying to find which instances are actually valid for the given service""" |
There was a problem hiding this comment.
Try and be more specific in your docstrings. Here's an example:
Given two lists of instances, return the intersection and difference of those two lists.
:param service_instances: the list of instances belonging to a services
:param args_instances: the desired instances
:returns: a tuple of (common, difference), indicating instances common to the two lists, and those only in args_instances
|
fix and 🚢 |
|
ship and iterate |
zeldinha
added a commit
that referenced
this pull request
Dec 2, 2015
Paasta rollback now accepts none, one or a list of instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paasta rollback now accepts none, one or a list of instances. If any are wrong it will give a warning and carry on with the valid ones.
Added a bunch of tests to verify the behaviour on each case.