Make local-run default to use bash if set to be interactive #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is an assumption here that 'bash' is always available. can this default to 'sh' instead? |
|
Eh... I would rather not. At Yelp we install bash on every base image, if people run this and it isn't available, it will just say bash is not available and they will have to figure out what shell they want to run. |
|
k. shipit |
solarkennedy
added a commit
that referenced
this pull request
Nov 23, 2015
Make local-run default to use bash if set to be interactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I this a small step towards ad-hoc "batches", I think a large portion will of the use cases will want to just get an interactive shell, so this makes it a little bit easier as you will be able to just say "-I"