Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail gracefully if you try and run paasta logs without scribe existing #66

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

Rob-Johnson
Copy link
Contributor

I'd like a better way of doing this - logic for dealing with missing scribereader is sprawled into a few places now. If anyone has a better suggestion, I'm open to discussion.

@mrtyler
Copy link
Contributor

mrtyler commented Nov 19, 2015

shipit

Where else is there special logic for this? I only see scribereader in logs.py and in associated tests (@pytest.mark.skipif goofiness), which is not too bad. I think adding the message where you did is ok. I agree that having it in one single canonical place would be better but I don't have brilliant ideas for how to do that while still swallowing ImportError in cases where we don't care about it.

@Rob-Johnson
Copy link
Contributor Author

well, there is already a try/catch ImportError/pass at the top of this file, 2 more try/catch ImportError/pass in test_cmd_logs.py and now this. I'll ship this as is - should only be temporary...right?

@Rob-Johnson Rob-Johnson merged commit 6095720 into master Nov 20, 2015
@Rob-Johnson Rob-Johnson deleted the paasta-logs-graceful-fail-without-scribe branch April 4, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants