Update chronos_serviceinit to use LastRunState #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob-Johnson
force-pushed
the
chronos-serviceinit-use-lastrunstate
branch
from
cc8118b to
5bbeffe
Compare
| @@ -61,7 +61,7 @@ def send_event_to_sensu(service, instance, monitoring_overrides, soa_dir, status | |||
|
|
|||
| def last_run_state_for_jobs(jobs): | |||
| """Map over a list of jobs to create a pair of (job, LasRunState)""" | |||
| return [(chronos_job, chronos_tools.get_status_last_run(chronos_job)) for chronos_job in jobs] | |||
| return [(chronos_job, chronos_tools.get_status_last_run(chronos_job)[-1]) for chronos_job in jobs] | |||
There was a problem hiding this comment.
What is the negative one in this case, is it the most recent run? If so can you make a comment explaining that?
There was a problem hiding this comment.
no, it's the lastrunstate in the pair of (time, lastrunstate) that's returned by chronos_tools.get_status_last_run(chronos_job). I'll add a comment.
|
fix + ship |
| @@ -202,7 +197,7 @@ def format_chronos_job_status(job, desired_state, running_tasks, verbose): | |||
| """ | |||
| config_hash = _format_config_hash(job) | |||
| disabled_state = _format_disabled_status(job) | |||
| (last_result, last_result_when) = _format_last_result(job) | |||
| last_result, formatted_time = _format_last_result(job) | |||
|
fix'n'ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic performed to calculate the formatted string in
chronos_serviceinitis now duplicating that available inchronos_tools.get_status_last_runfor calculating LastRunState. This removes that duplication, as well as updatingchronos_tools.get_status_last_runto return the date string with the state.I've updated tests + done some manual testing.
Here's a screenshot of the output: