Ensure chronos jobs have docker credentials to pull from the private registry #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we avoid hardcoding the location of this file? Here are the docs for this: https://mesosphere.github.io/marathon/docs/native-docker-private-registry.html in case anyone else wants them. |
|
We could. Let me do this one first so we can get feature parity with chronos and then I'll do a second pass and make it read from a config file or something. |
|
ok, I've raised #6 🚢 |
solarkennedy
added a commit
that referenced
this pull request
Oct 28, 2015
Ensure chronos jobs have docker credentials to pull from the private registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this in marathon, we should also do it in chronos.
The last we spoke with mesosphere this was the state of the art on dealing with private registries. (other than making your own docker wrapper)