Fix paasta status -vv
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #295 teaches `paasta status -v` to sort/truncate the list of non running Mesos tasks. It introduces the bug fixed by this commit.
| :param grey: If True, the list will be made less visually prominent. | ||
| :return output: Formatted output (list of output lines). | ||
| """ | ||
| if not grey: |
There was a problem hiding this comment.
What if the argument was just called color and it default to a noop (lambda?) and the called could pick? not a blocker just an alternative suggestion
There was a problem hiding this comment.
+1. default could be PaastaColors.white, and then colorize becomes lambda color_func: color_func(x)
|
ship |
|
shipit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #295 taught
paasta status -vto sort/truncate the list of non running Mesos tasks. It introduced a bug that brokepaasta status -vv: the truncated list of tasks was not consistently used throughout the code, leading to anCan only zip same-length listsexception.b974221 fixes said bug and updates the tests.
01df0ee attempts to remove some duplication in
status_mesos_tasks_verbose.