Make FileLogWriter, which writes json-formatted log lines to a specified file. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shipit. either with or without flock. |
| # https://docs.python.org/2/library/io.html#io.FileIO | ||
| # http://article.gmane.org/gmane.linux.kernel/43445 | ||
|
|
||
| to_write = format_log_line(level, cluster, service, instance, component, line) + self.line_delimeter |
There was a problem hiding this comment.
"%s%s" % (format_log_line(level, cluster, service, instance, component, line), self.line_delimeter)
|
ship |
EvanKrall
force-pushed
the
file_log_writer
branch
2 times, most recently
from
9153637 to
3a30b30
Compare
|
ship |
EvanKrall
force-pushed
the
file_log_writer
branch
from
3a30b30 to
c09cf6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #281 and fixes #64.
This branch makes another LogWriter implementation:
file, which writes to a specified file. I expect most people to want the file opened in append mode, so I've set that as the default.It also allows you to format the path based on service / component / level / cluster / instance, in case you want different files per service or something.
cc @hashbrowncipher for sanity-checking my usage of flock and io.