increased test coverage for marathon_tools #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjksmith
force-pushed
the
marathon_tools_tests
branch
from
858f2a5 to
257462c
Compare
| @@ -703,8 +709,6 @@ def get_proxy_port_for_instance(name, instance, cluster=None, soa_dir=DEFAULT_SO | |||
| :param cluster: The cluster to read the configuration for | |||
| :param soa_dir: The SOA config directory to read from | |||
| :returns: The proxy_port for the service instance, or None if not defined""" | |||
| if not cluster: | |||
There was a problem hiding this comment.
Hmm. I guess we pass this in all the time now?
|
ship |
mjksmith
added a commit
that referenced
this pull request
Mar 9, 2016
increased test coverage for marathon_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.