Add extra_constraints and pool to schemas for paasta validate #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you maybe rebase? I don't understand how these test failures are related. |
nhandler
force-pushed
the
update-schemas
branch
from
ea1057d to
78be1a1
Compare
|
That did it. Tests now pass. |
|
ship |
nhandler
added a commit
that referenced
this pull request
Feb 26, 2016
Add extra_constraints and pool to schemas for paasta validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
paasta validatecomplains about marathon/chronos configs that contain these keys. This change fixes that so they show up as valid.I am also wondering if it is worth adding some more logic around the constraints to make
paasta validateaware of invalid constraints.