validate dependent jobs' parents - issue 148 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -205,16 +207,27 @@ def validate_chronos(service_path): | |||
| service=service, clusters=[cluster], instance_type=instance_type, | |||
| soa_dir=soa_dir): | |||
| cjc = load_chronos_job_config(service, instance, cluster, False, soa_dir) | |||
| checks_passed, check_msgs = cjc.validate() | |||
| cjcs[service + '.' + cjc.get_job_name()] = cjc | |||
There was a problem hiding this comment.
This looks a little more complicated than I think it needs to be. While not super efficient, can it just be:
for parent in get_parents()
if parent not in get_services_for_cluster(cluster=cluster, instance_type=chronos):
# something
Yes. Using
|
…path that uses it #148
| @@ -201,12 +203,25 @@ def validate_chronos(service_path): | |||
|
|
|||
| returncode = True | |||
| for cluster in list_clusters(service, soa_dir, instance_type): | |||
| services_in_cluster = get_services_for_cluster(cluster=cluster, instance_type='chronos') | |||
| valid_services = set([name + '.' + instance for name, instance in services_in_cluster]) | |||
There was a problem hiding this comment.
"%s%s%s" % (service, ".", instance)
|
lgtm |
|
fix n ship |
giuliano108
added a commit
that referenced
this pull request
Feb 19, 2016
…sue-148 validate dependent jobs' parents - issue 148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #148 .
Catches two types of config errors:
service_name.instance_name). Similar to what the JSON schema also enforces.Note that the second validation won't let a "
ServiceAchild" depend on a "ServiceBparent". That's the best we can do without parsing the entireyelpsoa-configstree.In my opinion
paasta_tools/cli/cmds/validate.py, in order to validate the Chronos config, needs to know too many details aboutChronosJobConfig. If need be, I'm happy to move as much of that logic intopaasta_tools/chronos_tools.pyas possible, so that the latter is in charge of the validation and the former just prints out the outcome.