re-ordered default deploy order in fsm #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nitpick: breaking all four of stages with a bad staging deploy isn't usually the nicest could we do 1 stage by default and rest-of-stages after? |
|
Pull this into a system config file plz |
mjksmith
force-pushed
the
PAASTA-1084
branch
from
84f1a0f to
c10e934
Compare
mjksmith
force-pushed
the
PAASTA-1084
branch
from
ecf43bd to
b28844e
Compare
|
@asottile this probably won't be implemented now because either we pick a single stage to be the default for every new service, or we make users pick a default stage when they run |
|
@EvanKrall I forgot to mention this in standup (I thought it was done) but this is ready for more review/to ship |
|
This looks fine, just moving it to reading an external config file |
mjksmith
added a commit
that referenced
this pull request
Feb 17, 2016
re-ordered default deploy order in fsm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default deploy order to stage -> prod canary -> prod non-canary & dev
@EvanKrall @asottile you can argue for or against this here