Added experimental manual mesos task reconciliation script (orphan killer) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarkennedy
changed the title
| print "Killing %s. (%s)" % (container["Names"][0], mesos_task_id) | ||
| docker_client.kill(container) | ||
| else: | ||
| print "Would kill %s. (%s)" % (container["Names"][0], mesos_task_id) |
There was a problem hiding this comment.
Nitpick: Could you hint at using the --force option in this message?
|
+1 for adding the monitoring check. That would have been very helpful in catching/fixing this issue. |
|
Ship It! |
solarkennedy
added a commit
that referenced
this pull request
Feb 5, 2016
Added experimental manual mesos task reconciliation script (orphan killer)
| frameworks = state.get('frameworks') | ||
| executors = [ex for fw in frameworks for ex in fw.get('executors', []) | ||
| if u'TASK_RUNNING' in [t[u'state'] for t in ex.get('tasks', [])]] | ||
| return [e["id"] for e in executors] |
There was a problem hiding this comment.
return a set here to make this run in linear time instead of quadratic
Line 50 checks if a container id is in the running task ids for every container, and checking membership in a list is O(n) while checking membership in a set is O(1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental script that looks at the slave state and kills orphaned containers.
With the new mesos upgrade, it left behind a bunch. Some of the bug reports suggest that when you do upgrades to blow away the metadata..... In the future after we do an upgrade we can run this script in dry-run mode to see?
Comments welcome, but I want to ship this before the weekend so our boxes don't continue to have really full disks, bogus orphaned tasks running everywhere, and clusters out of resources.
Longer term maybe we can run this as a monitoring check, returning 0 if there is no bogus containers, and 1 if there is some.