Fail fast when contained dies in local-run. Resolves #213

[asottile]

No description provided.

[asottile]

this test was actually completely wrong! my changes ticked it so I fixed it

[asottile]

I also did some local testing with this branch:

Fast exiting

$ cli.py local-run -s www_pages
Local Makefile with 'cook-image' target detected. Assuming --build
Guesing cluster configuration for norcal-devb. To override, use the --cluster option.
Guessing instance configuration for main. To override, use the --instance option.
docker build -t paasta-local-run-www_pages-asottile .
Sending build context to Docker daemon 37.89 kB
Sending build context to Docker daemon 
Step 0 : FROM ubuntu:latest
 ---> 8693db7e8a00
Step 1 : CMD bash -exc echo RUNNING && exit 1
 ---> Using cache
 ---> 24dea624a3c6
Successfully built 24dea624a3c6
You're running a container in non-interactive mode.
This is how Mesos runs containers.
Note that some programs behave differently when running with no
tty attached (as your program is about to run).

Running docker command:
docker run <snip>
Found our container running with CID 93ffa70565dc494b0414e339c45e0a101b6f4de184647866a94a086397cedd52

Starting health check via http://dev25-devc.dev.yelpcorp.com:45028/status (waiting 60 seconds before considering failures due to grace period):
Healthcheck failed! (disregarded due to grace period)
Container exited with code 1
Your service failed to start, here is the stdout and stderr
+ echo RUNNING
+ exit 1
RUNNING

Stopping and removing the old container 93ffa70565dc494b0414e339c45e0a101b6f4de184647866a94a086397cedd52...
(Please wait or you may leave an orphaned container.)
...done

Slow exiting

$ cli.py local-run -s www_pages
Local Makefile with 'cook-image' target detected. Assuming --build
Guesing cluster configuration for norcal-devb. To override, use the --cluster option.
Guessing instance configuration for main. To override, use the --instance option.
docker build -t paasta-local-run-www_pages-asottile .
Sending build context to Docker daemon 37.89 kB
Sending build context to Docker daemon 
Step 0 : FROM ubuntu:latest
 ---> 8693db7e8a00
Step 1 : CMD bash -exc echo RUNNING && sleep 65 && exit 0
 ---> Using cache
 ---> 0b54b2d90e42
Successfully built 0b54b2d90e42
You're running a container in non-interactive mode.
This is how Mesos runs containers.
Note that some programs behave differently when running with no
tty attached (as your program is about to run).

Running docker command:
docker run <snip>
Found our container running with CID c7d0ced2c1d83219a7e17831b9ef22d59db67a4e503a70878f4917505988c91d

Starting health check via http://dev25-devc.dev.yelpcorp.com:53121/status (waiting 60 seconds before considering failures due to grace period):
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (disregarded due to grace period)
Healthcheck failed! (Attempt 1 of 30) (via: http://dev25-devc.dev.yelpcorp.com:53121/status)
Container exited with code 0
Your service failed to start, here is the stdout and stderr
+ echo RUNNING
+ sleep 65
RUNNING
+ exit 0

Stopping and removing the old container c7d0ced2c1d83219a7e17831b9ef22d59db67a4e503a70878f4917505988c91d...
(Please wait or you may leave an orphaned container.)
...done

[solarkennedy]

This looks great! Thanks so much!