Add a new itest to assert new services have a desired_state of start #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,3 +5,8 @@ Feature: Per-Service Deployments.json can be written and read back | |||
| When paasta stop is run against the repo | |||
| And we generate deployments.json for that service | |||
| Then that deployments.json can be read back correctly | |||
|
|
|||
| Scenario: New services have a desired_state of "start" | |||
| Given a test git repo is setup with commits | |||
There was a problem hiding this comment.
Does this work with the existing git-repo in place? In the previous scenario we run paasta "stop", so I guess we .. somehow clear out the git repo between scenarios?
There was a problem hiding this comment.
My understanding is that the context is cleared between the scenarios (and the tests appear to confirm that). This is also why I removed the shutil.rmtree call in the corresponding step (it would cause issues if you try and chain multiple 'then' steps).
|
Ship. When you do tdd on your tags thing, this test should fail. (will read back "deploy" as the desired state) then write some safeguard code and it should pass. |
nhandler
added a commit
that referenced
this pull request
Feb 4, 2016
Add a new itest to assert new services have a desired_state of start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new itest should avoid us adding code that modifies deployments.json in such a way that new services no longer have a desired_state of 'start'. This should help avoid incidents like #223 from happening again.