added support for old bugged refs/tags #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Given a test git repo is setup with commits | ||
| When we generate deployments.json for that service | ||
| Given a test git repo is setup with commits | ||
| When paasta stop is run against the repo |
There was a problem hiding this comment.
Thanks! This is good stuff.
|
fix + ship. I would like to get @EvanKrall's official opinion on this whole paasta-, paasta-paasta- nonsense. If the itest paases, then wfm |
| @@ -57,6 +60,30 @@ def step_impl_given(context): | |||
| context.expected_commit = commit.id | |||
|
|
|||
|
|
|||
| @when(u'paasta stop is run against the repo') | |||
There was a problem hiding this comment.
It might be nice to parameterize this step so that you can run any paasta command against it.
mjksmith
added a commit
that referenced
this pull request
Jan 29, 2016
added support for old bugged refs/tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugged == of the format 'paasta-paasta-cluster.instance'.
Also added an itest that makes sure generate deployments works properly with force_bounce and state tags.