Mark for deployment tags #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjksmith
force-pushed
the
master
branch
2 times, most recently
from
8bbb271 to
42ae5c2
Compare
|
lg2m. ship |
| @@ -975,6 +975,10 @@ def get_paasta_branch(cluster, instance): | |||
| return 'paasta-%s.%s' % (cluster, instance) | |||
|
|
|||
|
|
|||
| def get_paasta_tag(cluster, instance): | |||
| return get_paasta_branch(cluster, instance) | |||
There was a problem hiding this comment.
I think this is a good start, long term I think we need the type of tag that start/stop does with a timestamp. Otherwise we are moving this same tag over and over which is kinda gross.
There was a problem hiding this comment.
+1 do this before you ship this branch
|
You are going to have to rebase on top of @mjksmith's deploy_group changes carefully. |
nhandler
force-pushed
the
mark_for_deployment-tags
branch
from
29ccd85 to
71adfd6
Compare
|
ship |
nhandler
added a commit
that referenced
this pull request
Feb 3, 2016
Revert "Merge pull request #190 from Yelp/mark_for_deployment-tags"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to migrate us from branches to tags, this first pull request updates
mark_for_deploymentto tag as well as create a branch. Since branches are still being created like normal and no other code has been updated to switch from branches to tags, this should be a safe change.The change to CHAGNELOG.md was to make the pre-commit hook happy.