Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement 'pool': An attribute & constraint that lets you split a cluster #187

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

EvanKrall
Copy link
Member

...into multiple parts, without having to use Mesos's roles.

…ster into multiple parts, without having to use Mesos's roles.
@EvanKrall EvanKrall changed the title Implement 'pool': An attribute & constraint that lets you split a cluster WIP: Implement 'pool': An attribute & constraint that lets you split a cluster Jan 26, 2016
@EvanKrall
Copy link
Member Author

I've marked this as WIP because I want to be very careful about merging and rolling this out. As is, this will cause a large bounce.

@@ -218,6 +218,18 @@ def get_extra_volumes(self):
<https://mesosphere.github.io/marathon/docs/native-docker.html>`_"""
return self.config_dict.get('extra_volumes', [])

def get_pool(self):
"""Which pool of nodes this job should run on. This can be used to mitigate noisy neighbors, by putting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these docs, or some of them to the actual docs location?

@solarkennedy
Copy link
Contributor

Are you sure you don't want to do the thing where if pool is not None, add the constraint?

Also of course we'll need to add the attributes to our slaves now

@EvanKrall
Copy link
Member Author

I'm not sure what you mean in your first sentence. My default behavior is pretty clearly specified: a constraint of ['pool', 'LIKE', 'default'].

I've got an internal review for adding the attribute to our slaves.

@mjksmith mjksmith force-pushed the master branch 2 times, most recently from 8bbb271 to 42ae5c2 Compare January 27, 2016 03:19
@solarkennedy
Copy link
Contributor

Gotcha, it sound like you are going to deploy the new attribute first, and then optionally add this constraint to a bunch of apps, then push this code?

@EvanKrall
Copy link
Member Author

Yeah, that's the plan.

@EvanKrall EvanKrall merged commit f31f0cc into master Feb 3, 2016
@asottile asottile deleted the pools branch May 31, 2016 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants