added a HOST variable to docker containers #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -566,6 +569,11 @@ def get_instance_config(service, instance, cluster, soa_dir, load_deployments=Fa | |||
| ) | |||
|
|
|||
|
|
|||
| def get_hostname(): | |||
| (_, hostname) = _run('hostname') | |||
There was a problem hiding this comment.
Heh, socket.getfqdn would be ok
this mimics mesos' behaviour also made the OOM message more verbose
|
lg2m. 🚢 |
mjksmith
added a commit
that referenced
this pull request
Jan 26, 2016
added a HOST variable to docker containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker containers created by local_run will now have a $HOST variable containing the hostname of the machine the container is running on.