-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to internal CEP/SCF stuff #17
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
soa-configs | ||
=========== | ||
|
||
soa-configs are the shared configuration storage that PaaSTA uses to hold the | ||
description and configuration of what services exist and how they should be | ||
deployed and monitored. | ||
|
||
This directory needs to be deployed globally in the same location to every | ||
server that runs any PaaSTA component. | ||
|
||
PaaSTA reads particular config files for each service in the soa-configs | ||
directory. There is one folder per service. Here is an example tree:: | ||
|
||
soa-configs | ||
├── web | ||
│ ├── deploy.yaml | ||
│ ├── marathon-dev.yaml | ||
│ ├── marathon-prod.yaml | ||
│ ├── monitoring.yaml | ||
│ ├── service.yaml | ||
│ └── smartstack.yaml | ||
├── api | ||
│ ├── deploy.yaml | ||
│ ├── marathon-dev.yaml | ||
│ ├── marathon-prod.yaml | ||
│ ├── monitoring.yaml | ||
│ ├── service.yaml | ||
│ └── smartstack.yaml | ||
... | ||
|
||
See the `paasta-specific soa-configs documentation <yelpsoa-configs.html>`_ for more information | ||
about the structure and contents of some example files in soa-configs that PaaSTA uses. | ||
|
||
For more information about why we chose this method of config distribution, | ||
watch `this talk on Yelp's soa-configs and how it is used <https://vimeo.com/141231345>`_. | ||
|
||
For reading soa-configs, PaaSTA uses `service_configuration_lib <https://github.com/Yelp/service_configuration_lib>`_. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
general_itests/fake_soa_configs_fsm_wizard/legacy_service/service.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
--- | ||
deployed_to: [] | ||
description: Please fill in a one-line description of this service | ||
external_link: Please add a url to your CEP or SCF here | ||
description: "" | ||
external_link: "" | ||
runs_on: | ||
- host1 | ||
- host2 | ||
- host3 | ||
- host3 |
4 changes: 2 additions & 2 deletions
4
general_itests/fake_soa_configs_fsm_wizard/paasta_service/service.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
--- | ||
description: Please fill in a one-line description of this service | ||
external_link: Please add a url to your CEP or SCF here | ||
description: "" | ||
external_link: "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,14 +52,16 @@ def get_description(description, auto): | |
def get_external_link(link, auto): | ||
if link is None: | ||
if auto: | ||
link = "Please add a url to your CEP or SCF here" | ||
link = "Please add a link to a reference doc for your service" | ||
while not link: | ||
link = ask('Link to your CEP or SCF?') | ||
link = ask('Link to a reference doc?') | ||
return link | ||
|
||
|
||
def get_smartstack_stanza(yelpsoa_config_root, auto, port): | ||
"""Produce a smartstack.yaml a la http://y/cep319""" | ||
"""Produce a basic smartstack.yaml in a `format <yelpsoa_configs.html#smartstack-yaml>`_ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be nice to continue to link to docs about this. I guess this requires your TODO about nerve/synapse docs? |
||
PaaSTA can use. | ||
""" | ||
if port is None: | ||
suggested_port = suggest_smartstack_proxy_port(yelpsoa_config_root) | ||
if auto: | ||
|
@@ -89,8 +91,8 @@ def get_service_stanza(description, external_link, auto): | |
|
||
|
||
def get_monitoring_stanza(auto, team, legacy_style=False): | ||
"""Produce a monitoring.yaml a la | ||
https://trac.yelpcorp.com/wiki/HowToService/Monitoring/monitoring.yaml | ||
"""Produce a monitoring.yaml in a `format <yelpsoa_configs.html#monitoring-yaml>`_ | ||
that PaaSTA can read. | ||
|
||
'team' is the critical key and is not calculable so it is required. | ||
|
||
|
@@ -159,7 +161,7 @@ def get_clusternames_from_deploy_stanza(deploy_stanza): | |
|
||
def get_marathon_stanza(): | ||
"""Produce a ``marathon-*.yaml`` a la | ||
http://servicedocs.yelpcorp.com/docs/paasta_tools/yelpsoa_configs.html#marathon-clustername-yaml | ||
`the docs <yelpsoa_configs.html#marathon-clustername-yaml>`_ | ||
|
||
We want to default to The Simplest Thing That Can Possibly Work. This | ||
allows new services to hit the ground running, but forces developers to | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend deleting anything in cep139 that duplicates information we have in our docs to prevent drift. Instead, provide links to the canonical docs (here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do