Allow users to set accepted_resource_roles in marathon yamls. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will also need to update |
|
Can you update the docs as well? This is going to cause a big bounce too right? :( |
|
@solarkennedy Yeah, this would cause a large bounce. We could avoid that by using the Should I try to do that? |
|
I've made it so that the config dict doesn't contain |
Conflicts: paasta_tools/marathon_tools.py tests/test_marathon_tools.py
EvanKrall
added a commit
that referenced
this pull request
Jan 19, 2016
Allow users to set accepted_resource_roles in marathon yamls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal ticket PAASTA-2455.
This passes the
accepted_resource_rolesparameter through marathon.yaml into the marathon config, allowing for apps to be deployed to dedicated hardware.