Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider chronos*.yaml for deploy checks (Closes: #110) #162

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

nhandler
Copy link
Contributor

This will avoid paasta check message such as:

✗ There are some instance(s) in deploy.yaml that are not referenced
  by any marathon instance:
  cluster-name.batch-name, cluster-name2.batch-name
  You should probably delete these deploy.yaml entries if they are unused.

when there is a chronos-*.yaml file referencing the instance.

This change also will not show:

✗ No marathon.yaml exists, so your service cannot be deployed.
  Push a marathon-[superregion].yaml and run `paasta generate-pipeline`.
  More info: http://y/yelpsoa-configs

if a chronos.yaml file exists (and will show a more accurate message if neither yaml file exists).

Closes #110

@nhandler nhandler self-assigned this Jan 14, 2016
@solarkennedy
Copy link
Contributor

ship

nhandler added a commit that referenced this pull request Jan 15, 2016
Consider chronos*.yaml for deploy checks (Closes: #110)
@nhandler nhandler merged commit 5a424c1 into master Jan 15, 2016
@nhandler nhandler deleted the consider-chronos-yaml-deploy-check branch January 15, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants