Make paasta check call validate (Closes #128) #161
Conversation
| @@ -308,6 +309,7 @@ def paasta_check(args): | |||
| marathon_deployments_check(service_path) | |||
| sensu_check(service, service_path) | |||
| smartstack_check(service, service_path) | |||
| paasta_validate(None, service_path) | |||
There was a problem hiding this comment.
I'm always confused when I see this kind of "None" thing in an arg. None what?
Can you kwargs this?
|
Did a bit of refactoring to make |
| if not service_path or not os.path.isdir(service_path): | ||
| print failure("%s is not a directory" % service_path, | ||
| "http://paasta.readthedocs.org/en/latest/yelpsoa_configs.html") | ||
| return 1 |
There was a problem hiding this comment.
I know this follows the pattern set in the rest of the file, but I'd really like to see these 0s and 1s changed to True or False and turned to the right exit code at exit time
There was a problem hiding this comment.
That is fine. The reason I went for the numeric approach is to allow us to easily extend this command to have multipole failure return values that we can handle in different ways. But I am fine changing it to the cleaner True/False for now.
|
afaict this looks fine. This is one of those things that will need a manual test to be sure, then ship. |
nhandler
force-pushed
the
paasta-check-validate
branch
from
04a48e1 to
d18e6a8
Compare
Make paasta check call validate (Closes #128)
This will allow
paasta checkto notify users of additional errors with their service. It will catch things such as invalid yelpsoa config syntax (based on the jsonschemas) and invalid chronos schedules.Closes #128