Make deploy_chronos_services shuffle #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shuf command shuffles lines, but list_chronos_jobs outputs 1
space-delimited line. This fixes #154
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| if am_i_mesos_leader >/dev/null; then | |||
| list_chronos_jobs | shuf | xargs -n 1 -r -P 5 setup_chronos_job | |||
| list_chronos_jobs | tr ' ' '\n' | shuf | xargs -n 1 -r -P 5 setup_chronos_job | |||
There was a problem hiding this comment.
This is... fine I think. What if list_chronos_jobs (and list_marathon_jobs) did one per line anyway?
There was a problem hiding this comment.
I thought about that, but I got worried that people might have scripts parsing that output (similar to how we do that with deploy_chronos_jobs) which would break after such a change. This approach seemed like the easiest and safest solution to the problem.
If we are fine possibly breaking some scripts, I can modify list_chronos_jobs.
… list one item per line
|
ship |
nhandler
added a commit
that referenced
this pull request
Jan 14, 2016
Make deploy_chronos_services shuffle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shuf command shuffles lines, but list_chronos_jobs outputs 1
space-delimited line. This fixes #154