Added a script to drain and kill a marathon app as gracefully as possible #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if not marathon_tools.is_app_id_running(app_id=full_appid, client=client): | ||
| print("Couldn't find an app named {0}".format(full_appid)) | ||
| quit() |
|
fine first pass, some tests would be good though. |
mjksmith
changed the title
| @@ -394,6 +395,15 @@ def get_healthcheck_mode(self, _): | |||
| # Healthchecks are not supported yet in chronos | |||
| return None | |||
|
|
|||
| def get_desired_state_human(self): | |||
There was a problem hiding this comment.
Is this.. just a bad rebase/merge? This should be in master already.
mjksmith
force-pushed
the
PAASTA-1889
branch
3 times, most recently
from
b709db7 to
d3e67d3
Compare
|
double check the tests and ship |
mjksmith
added a commit
that referenced
this pull request
Jan 21, 2016
Added a script to drain and kill a marathon app as gracefully as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script to drain and kill a marathon app.