Validate chronos #134
Merged
Validate chronos #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for cluster in list_clusters(service, soa_dir, instance_type): | ||
| for instance in list_all_instances_for_service(service, instance_type, soa_dir): | ||
| cjc = load_chronos_job_config(service, instance, cluster, False, soa_dir) | ||
| (checks_passed, check_msgs) = cjc.validate() |
There was a problem hiding this comment.
you don't need to wrap these in brackets.
|
@solarkennedy Added the clusters argument back to list_all_instances_for_service. I think that addresses the last outstanding issue needing fixing. |
| def path_to_soa_dir_service(service_path): | ||
| soa_dir = os.path.dirname(service_path) | ||
| service = os.path.basename(service_path) | ||
|
|
nhandler
force-pushed
the
paasta-validate-chronos
branch
from
9462d05 to
3ff7737
Compare
|
Got a verbal ship-it, so I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some chronos validation to the
paasta validatecommand. This fixes #127