Fix --help for local-run and add a test #108

asottile · 2015-12-03T19:52:17Z

Also simplified (and accurately named) the thing that discovers all the command modules.

solarkennedy · 2015-12-03T20:59:01Z

tests/paasta_cli/test_cmds_help.py

+    return choices
+
+
+@pytest.mark.parametrize('cmd', each_command())


Whoa, far out.

solarkennedy · 2015-12-03T20:59:11Z

Thanks!

Fix --help for local-run and add a test

Fix --help for local-run and add a test

d0d9a9e

solarkennedy reviewed Dec 3, 2015
View reviewed changes

tests/paasta_cli/test_cmds_help.py

return choices

@pytest.mark.parametrize('cmd', each_command())

Copy link

Contributor

solarkennedy Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, far out.

solarkennedy added a commit that referenced this pull request Dec 3, 2015

Merge pull request #108 from asottile/fix_helps

a1843d1

Fix --help for local-run and add a test

solarkennedy merged commit a1843d1 into Yelp:master Dec 3, 2015

asottile deleted the fix_helps branch December 3, 2015 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix --help for local-run and add a test #108

Fix --help for local-run and add a test #108

asottile commented Dec 3, 2015

solarkennedy Dec 3, 2015

solarkennedy commented Dec 3, 2015

		return choices


		@pytest.mark.parametrize('cmd', each_command())

Fix --help for local-run and add a test #108

Fix --help for local-run and add a test #108

Conversation

asottile commented Dec 3, 2015

solarkennedy Dec 3, 2015

Choose a reason for hiding this comment

solarkennedy commented Dec 3, 2015