Update packer-provisioner-goss.go #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom Gossfile suport (the --gossfile flag) Tests now supports uploading directories - ignore support disabled (for now) Username and Password for auth to download goss from custom authed locations Ssl cert check disable option - for internal services using self-signed certs modified: README.md modified: packer-provisioner-goss.go
|
Hi @fishnix, Sorry about this, this should be much cleaner. |
|
Thanks @vamegh, I'll try to have a look today and get it merged up. Cheers! |
Cleaned up the code, trying to make it DRY, now using functions with switch statements to deal with curl / wget cases. Added an extra UseSudo / use_sudo flag which will run goss with sudo enabled, passwordless sudo access must be provided for this to work.
fishnix
suggested changes
Feb 9, 2018
README.md
Outdated
| "use_sudo": false, | ||
| "goss_file": "", | ||
| "Username": "", | ||
| "Password": "", |
There was a problem hiding this comment.
These should be username and password
packer-provisioner-goss.go
Outdated
| @@ -144,6 +159,12 @@ func (p *Provisioner) Provision(ui packer.Ui, comm packer.Communicator) error { | |||
| if err := p.uploadFile(ui, comm, dst, src); err != nil { | |||
| return fmt.Errorf("Error uploading goss test: %s", err) | |||
| } | |||
| } else if s.Mode().IsDir() == true { | |||
There was a problem hiding this comment.
} else if s.Mode().IsDir() {
also, you can fix the one above it too :)
packer-provisioner-goss.go
Outdated
| @@ -211,6 +234,49 @@ func (p *Provisioner) debug() string { | |||
| return "" | |||
| } | |||
|
|
|||
| func (p *Provisioner) sslFlag(cmdType string) string { | |||
| if p.config.SkipSSLChk == true { | |||
packer-provisioner-goss.go
Outdated
|
|
||
| // enable sudo if required | ||
| func (p *Provisioner) enableSudo() string { | ||
| if p.config.UseSudo == true { |
Removed all unneccessary comparison to true operators. fixed case for username and password in readme.md modified: README.md modified: packer-provisioner-goss.go
|
Hi @fishnix should be fixed now, I've cleaned up all of the equal to true comparisons and fixed the readme as requested. |
|
Just for information: I merged the PR and created a new release here: https://github.com/widdix/packer-provisioner-goss/releases/tag/v0.1.1 I would prefer if we could have the release in this project instead of a fork. |
|
Thanks for the ping @michaelwittig I didn't notice the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Gossfile suport (the --gossfile flag)
Tests now supports uploading directories - ignore support disabled (for now)
Username and Password for auth to download goss from custom authed locations
Ssl cert check disable option - for internal services using self-signed certs