Update to packer-plugin-sdk v0.0.11 and regenerate HCL config #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @frightenedmonkey thanks for this PR! Will this break backwards compatibility with older versions of packer? Also, I've recently merged and released Windows support which will require you to rebase and regenerate your hcl spec. Thanks! |
|
@fishnix I'll rebase. With regard to backwards compatibility, unfortunately, Hashicorp broke it with the update. If you review their guide on upgrading to 1.7 templates, you can see the table I've screenshot below:
I don't have a solution for that, unfortunately. |
|
Ok thanks, we can probably release this as a major version upgrade then. Does that seem reasonable? |
|
SGTM; I appreciate you being receptive! |
The packer 1.7 release changed the protocol version to 5 (also, notably, the plugin SDK didn't correctly format the protocol information as expected until v0.0.11). Running the packer-sdk-migrator tool mostly worked, but left a couple of issues with fields in the config marked as unused. It appears that the changes to HCL and how mapstructure decodes things requires that you annotated basic fields with mapstructure struct tags that don't follow the default mapping.
The template/interpolate package has been moved to the packer-plugin-sdk repository. This fixes the tests after rebasing.
frightenedmonkey
force-pushed
the
update-to-1-7
branch
from
4512000 to
8ca5ef3
Compare
|
@fishnix rebased & tests are passing locally for me (nice to get some :-D) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packer 1.7 release changed the protocol version to 5 (also, notably,
the plugin SDK didn't correctly format the protocol information as
expected until v0.0.11). Running the packer-sdk-migrator tool mostly
worked, but left a couple of issues with fields in the config marked as
unused. It appears that the changes to HCL—and how mapstructure decodes
things—requires that you annotate basic fields with mapstructure
struct tags when the fields don't follow the default mapping.
This change resolves #42