This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
[1288] Refactor scopes into Query Objects #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, assuming this build is green we should be ready for review! |
|
Looks solid |
|
Great, thanks. I'll squash and merge; if you could re-review afterwards just to be sure that would be great 😄 |
orenyk
force-pushed
the
1288_refactor_scopes_module
branch
from
b002597 to
5c3b89c
Compare
|
Ok, ready for re-review! |
|
Looks good, except it's out of date with master again =/ |
|
Not according to GitHub... are you sure? I'll rebase just for kicks and merge if everything is fine. |
Resolves #1288 - add a set of POROs for Query Objects where appropriate - move reservation scopes back into the model file - update code where necessary
orenyk
force-pushed
the
1288_refactor_scopes_module
branch
from
5c3b89c to
799a46c
Compare
|
Yea, no merge conflicts. Just waiting for Travis to finish up... |
orenyk
added a commit
that referenced
this pull request
Jan 12, 2016
[1288] Refactor scopes into Query Objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress, figuring out the final tweaks.
Resolves #1288