Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

[724] Set minimum height for Reservations table #1349

Merged
merged 1 commit into from
Nov 23, 2015
Merged

[724] Set minimum height for Reservations table #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/assets/stylesheets/reservations/_index.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@
border-radius: 5px;
margin-bottom: 20px;
}

#reservations-list {
height: 10em;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this better than min-height for this use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little-known fact - tables don't have a min-height property; way to not read the issue thread 😛.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao thanks, I was looking at PRs I didn't see the issue xD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you teach me that the first step of code review is to read the relevant issue? Maybe I just made it up 😛

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on the level of code review ^_~

  1. shallow - cursory-glance feedback for obvious little things
  2. read-only - for style/architecture
  3. clone-and-manually-test - needed sometimes

Feedback of type 1 from busy people (Adam lol) has helped me more often than you'd think :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, much appreciated 😄. Does that mean this PR gets your stamp of approval? Also, do you mind checking out my comment in #1288 and seeing if what I concluded makes sense? Thanks!

}
2 changes: 1 addition & 1 deletion app/views/reservations/_reservations_list.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<table id="table_woo" class="datatable table table-striped table-bordered">
<table id="reservations-list" class="datatable table table-striped table-bordered">
<thead>
<tr>
<th>#</th>
Expand Down