You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
So, while reviewing #1350 we ran into an issue where we needed seemingly duplicate statements in ability.rb to handle checkout person authorization despite the fact that it appeared as it should be definable in just one when block. Unfortunately, due to the way Ruby case statements work, we're never actually getting into that when block for checkout persons. Fortunately, all of the abilities in that block are subsets of abilities in the matching checkout person block, so we haven't ever noticed this fact.
We should refactor ability.rb to properly handle role inheritance (this seems like a good setup) so that everything is cleaner and makes more sense.
The text was updated successfully, but these errors were encountered:
So, while reviewing #1350 we ran into an issue where we needed seemingly duplicate statements in
ability.rb
to handle checkout person authorization despite the fact that it appeared as it should be definable in just onewhen
block. Unfortunately, due to the way Rubycase
statements work, we're never actually getting into that when block for checkout persons. Fortunately, all of the abilities in that block are subsets of abilities in the matching checkout person block, so we haven't ever noticed this fact.We should refactor
ability.rb
to properly handle role inheritance (this seems like a good setup) so that everything is cleaner and makes more sense.The text was updated successfully, but these errors were encountered: